Comments on: The missing sources part 2 http://www.mozzarellaincarrozza.it/harbour/the-missing-sources-part-2/ From Clipper 87 to Harbour running on... everything Thu, 15 Jan 2015 22:01:42 +0000 hourly 1 http://wordpress.org/?v=4.1.3 By: Francesco http://www.mozzarellaincarrozza.it/harbour/the-missing-sources-part-2/#comment-237 Thu, 15 Jan 2015 22:01:42 +0000 http://www.mozzarellaincarrozza.it/harbour/?p=137#comment-237 Thanks Maurizio.

Yes, programming isn’t an exact science. And infact aMaxStrLen can be written in different ways… it would be nice to list some of them and analyze which is the best for speed and/or readability…

I will comment on my version of the code in a dedicated post.

]]> By: Maurizio la Cecilia http://www.mozzarellaincarrozza.it/harbour/the-missing-sources-part-2/#comment-236 Thu, 15 Jan 2015 16:27:22 +0000 http://www.mozzarellaincarrozza.it/harbour/?p=137#comment-236 Hi Francesco,
really an interesting and well done blog. A clear and comprehensive path to obtain an effective port.

About your csrput() ported version I think that:
1. the SAY “” is unnecessary and you can omit it at all;
2. the @ y,x is always pre-processed to SetPos( y, x );
3. the original FuncKy function returns NIL.
So, I suggest this code:

FUNCTION csrput( y, x )
   SetPos( y, x )
   return nil

In addition, here is my ancient version of aMaxStrLen(), just to show that programming isn’t an exact science:

FUNCTION aMaxStrLen( aArr )

   LOCAL nMaxLen := 0

   AEval( aArr, { | e | nMaxLen := Max( nMaxLen, IIf( HB_IsString( e ), Len( e ), 0 ) ) } )
   RETURN nMaxLen

Waiting for the next post.
Thanks a lot.
Maurizio

]]>